[PATCH v2 03/19] rsatoc: remove unnecessary function call

Ahmad Fatoum a.fatoum at pengutronix.de
Mon Aug 5 02:29:33 PDT 2024


On 01.08.24 07:57, Sascha Hauer wrote:
> Calling ENGINE_set_default_RSA() doesn't seem appropriate for upcoming
> ECDSA support. I don't know what the call is good for, it works without
> it, so remove it.
> 
> Signed-off-by: Sascha Hauer <s.hauer at pengutronix.de>

Acked-by: Ahmad Fatoum <a.fatoum at pengutronix.de>

> ---
>  scripts/rsatoc.c | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/scripts/rsatoc.c b/scripts/rsatoc.c
> index ed167bf247..37728899f8 100644
> --- a/scripts/rsatoc.c
> +++ b/scripts/rsatoc.c
> @@ -289,12 +289,6 @@ static int rsa_engine_init(ENGINE **pe)
>  		}
>  	}
>  
> -	if (!ENGINE_set_default_RSA(e)) {
> -		fprintf(stderr, "Couldn't set engine as default for RSA\n");
> -		ret = -1;
> -		goto err_set_rsa;
> -	}
> -
>  	*pe = e;
>  
>  	return 0;

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |




More information about the barebox mailing list