[PATCH v2 1/2] scripts: omap3-usb-loader: fix heap overflow
Sascha Hauer
s.hauer at pengutronix.de
Wed May 31 03:26:08 PDT 2023
From: Ahmad Fatoum <ahmad at a3f.at>
Newer GCC versions correctly warn that the buffer allocated by realloc
is too small. Correct the size.
Signed-off-by: Ahmad Fatoum <ahmad at a3f.at>
Link: https://lore.barebox.org/20230531062703.670521-3-ahmad@a3f.at
Signed-off-by: Sascha Hauer <s.hauer at pengutronix.de>
---
scripts/omap3-usb-loader.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/omap3-usb-loader.c b/scripts/omap3-usb-loader.c
index a8d626c32f..31a03be8e7 100644
--- a/scripts/omap3-usb-loader.c
+++ b/scripts/omap3-usb-loader.c
@@ -784,7 +784,7 @@ int main(int argc, char *argv[])
file.addr = OMAP_BASE_ADDRESS;
/* commit the file object with the processor specified base address */
- args->files = realloc(args->files, filecount);
+ args->files = realloc(args->files, filecount * sizeof(*args->files));
args->numfiles = filecount;
args->files[filecount - 1] = malloc(sizeof (file));
memcpy(args->files[filecount - 1], &file, sizeof (file));
--
2.39.2
More information about the barebox
mailing list