[PATCH v2 1/7] crypto: digest: match driver name if no algo name matches
Ahmad Fatoum
a.fatoum at pengutronix.de
Thu May 25 23:37:40 PDT 2023
The digest command lists all registered digest implementations, but
there's no way to select a specific implementation when another higher
priority one exists for the same algorithm. Let's support this, by
having digest_algo_get_by_name fallback to look up by driver name if an
exact match couldn't be found by algo name.
Signed-off-by: Ahmad Fatoum <a.fatoum at pengutronix.de>
---
commands/digest.c | 2 +-
crypto/digest.c | 11 ++++++-----
2 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/commands/digest.c b/commands/digest.c
index b7ed4d50af1f..e57920e58268 100644
--- a/commands/digest.c
+++ b/commands/digest.c
@@ -190,7 +190,7 @@ static int do_digest(int argc, char *argv[])
BAREBOX_CMD_HELP_START(digest)
BAREBOX_CMD_HELP_TEXT("Calculate a digest over a FILE or a memory area.")
BAREBOX_CMD_HELP_TEXT("Options:")
-BAREBOX_CMD_HELP_OPT ("-a <algo>\t", "hash or signature algorithm to use")
+BAREBOX_CMD_HELP_OPT ("-a <algo>\t", "hash or signature algorithm name/driver to use")
BAREBOX_CMD_HELP_OPT ("-k <key>\t", "use supplied <key> (ASCII or hex) for MAC")
BAREBOX_CMD_HELP_OPT ("-K <file>\t", "use key from <file> (binary) for MAC")
BAREBOX_CMD_HELP_OPT ("-s <hex>\t", "verify data against supplied <hex> (hash, MAC or signature)")
diff --git a/crypto/digest.c b/crypto/digest.c
index 621d3841686e..dd2c2ee317ed 100644
--- a/crypto/digest.c
+++ b/crypto/digest.c
@@ -27,8 +27,6 @@
static LIST_HEAD(digests);
-static struct digest_algo *digest_algo_get_by_name(const char *name);
-
static int dummy_init(struct digest *d)
{
return 0;
@@ -106,7 +104,7 @@ EXPORT_SYMBOL(digest_algo_unregister);
static struct digest_algo *digest_algo_get_by_name(const char *name)
{
- struct digest_algo *d = NULL;
+ struct digest_algo *d_by_name = NULL, *d_by_driver = NULL;
struct digest_algo *tmp;
int priority = -1;
@@ -114,17 +112,20 @@ static struct digest_algo *digest_algo_get_by_name(const char *name)
return NULL;
list_for_each_entry(tmp, &digests, list) {
+ if (strcmp(tmp->base.driver_name, name) == 0)
+ d_by_driver = tmp;
+
if (strcmp(tmp->base.name, name) != 0)
continue;
if (tmp->base.priority <= priority)
continue;
- d = tmp;
+ d_by_name = tmp;
priority = tmp->base.priority;
}
- return d;
+ return d_by_name ?: d_by_driver;
}
static struct digest_algo *digest_algo_get_by_algo(enum hash_algo algo)
--
2.39.2
More information about the barebox
mailing list