[PATCH] fixup! pci: set upper word for 64bit base addresses

Ahmad Fatoum a.fatoum at pengutronix.de
Mon May 22 22:50:42 PDT 2023


pci: fix warning building for 32-bit

On systems with sizeof(resource_size_t) == 4, shifting by 32 will result
in a warning. Use the upper_32_bits macro to fix this.

Signed-off-by: Ahmad Fatoum <a.fatoum at pengutronix.de>
---
 drivers/pci/pci.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
index 046711cd145b..ff2ffacffb6b 100644
--- a/drivers/pci/pci.c
+++ b/drivers/pci/pci.c
@@ -223,7 +223,8 @@ static void setup_device(struct pci_dev *dev, int max_bar)
 			*last_addr = ALIGN(*last_addr, size);
 			pci_write_config_dword(dev, pci_base_address_0, *last_addr);
 			if (mask & PCI_BASE_ADDRESS_MEM_TYPE_64)
-				pci_write_config_dword(dev, pci_base_address_1, *last_addr >> 32);
+				pci_write_config_dword(dev, pci_base_address_1,
+						       upper_32_bits(*last_addr));
 			start = *last_addr;
 			*last_addr += size;
 		} else {
-- 
2.39.2




More information about the barebox mailing list