[PATCH] usb: dwc3: gadget: lower informal user notifaction dequeue operation

Marco Felsch m.felsch at pengutronix.de
Thu Mar 23 10:30:16 PDT 2023


I encounted the below error message on the i.MX8MP if a fastboot gadget
was up and running and barebox does a reset() or boots the kernel:

  ERROR: dwc3 38100000.usb at 38100000.of: request 00000000bfd91568 was not queued to ep1out

Printing an error message during usb_ep_dequeue() is more confusing than
helpful since the usb_ep_dequeue() could be called during unbind() like
it is done for fastboot. Lower the dev_err() message to dev_dbg() to
keep the message for developers.

Signed-off-by: Marco Felsch <m.felsch at pengutronix.de>
---
 drivers/usb/dwc3/gadget.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
index 48be74f7e9..ffe4f30c67 100644
--- a/drivers/usb/dwc3/gadget.c
+++ b/drivers/usb/dwc3/gadget.c
@@ -1955,7 +1955,7 @@ static int dwc3_gadget_ep_dequeue(struct usb_ep *ep,
 		}
 	}
 
-	dev_err(dwc->dev, "request %pK was not queued to %s\n",
+	dev_dbg(dwc->dev, "request %pK was not queued to %s\n",
 		request, ep->name);
 	ret = -EINVAL;
 out:
-- 
2.30.2




More information about the barebox mailing list