[RFC 1/2] dma: rework dma_sync_single interface
Sascha Hauer
s.hauer at pengutronix.de
Fri Mar 3 02:06:20 PST 2023
Hi Denis,
On Tue, Feb 28, 2023 at 01:32:47PM +0300, Denis Orlov wrote:
> -#ifndef dma_sync_single_for_device
> -static inline void dma_sync_single_for_device(dma_addr_t address, size_t size,
> - enum dma_data_direction dir)
> +#ifndef arch_sync_dma_for_device
> +void arch_sync_dma_for_device(void *vaddr, size_t size,
> + enum dma_data_direction dir);
> {
> - barrier_data((void *)address);
> + barrier_data(address);
> }
> #endif
"static inline" is missing here. Also "address" should be "vaddr".
With that fixed imx_v7_defconfig compiles successfully and from what I
can tell also works.
I haven't looked into this patch yet. Passing a struct device to the
dma_sync functions is a step into the right direction for sure.
Ultimately both patches should be merged to avoid bisecting failures.
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
More information about the barebox
mailing list