[PATCH 2/3] scripts: mxsimage: re-use crc32 implementation from crypto/crc32.c

Sascha Hauer s.hauer at pengutronix.de
Tue Dec 12 00:16:22 PST 2023


We already have crc32_be in the tree, so re-use that.

Signed-off-by: Sascha Hauer <s.hauer at pengutronix.de>
---
 scripts/mxsimage.c | 49 +++++-----------------------------------------
 1 file changed, 5 insertions(+), 44 deletions(-)

diff --git a/scripts/mxsimage.c b/scripts/mxsimage.c
index d33c4c8a0a..cebbab25ad 100644
--- a/scripts/mxsimage.c
+++ b/scripts/mxsimage.c
@@ -15,6 +15,10 @@
 #include <arpa/inet.h>
 #include <linux/kernel.h>
 
+#include "common.h"
+#include "common.c"
+#include "../crypto/crc32.c"
+
 #define SB_BLOCK_SIZE		16
 
 static char *prepfile;
@@ -376,38 +380,6 @@ struct sb_image_ctx {
  *                         JTAG/SPI2_EEPROM/SD_SSP0/SD_SSP1
  */
 
-static uint32_t crc_table[256];
-static int crc_table_valid;
-
-static void make_crc_table(void)
-{
-	uint32_t mask;
-	int i, j;
-	uint32_t poly; /* polynomial exclusive-or pattern */
-
-	if (crc_table_valid)
-		return;
-
-	/*
-	 * the polynomial used by PBL is 1 + x1 + x2 + x4 + x5 + x7 + x8 + x10
-	 * + x11 + x12 + x16 + x22 + x23 + x26 + x32.
-	 */
-	poly = 0x04c11db7;
-
-	for (i = 0; i < 256; i++) {
-		mask = i << 24;
-		for (j = 0; j < 8; j++) {
-			if (mask & 0x80000000)
-				mask = (mask << 1) ^ poly;
-			else
-				mask <<= 1;
-		}
-		crc_table[i] = mask;
-	}
-
-	crc_table_valid = 1;
-}
-
 /*
  * OpenSSL 1.1.0 and newer compatibility functions:
  * https://wiki.openssl.org/index.php/1.1_API_Changes
@@ -441,18 +413,7 @@ int EVP_CIPHER_CTX_reset(EVP_CIPHER_CTX *ctx)
 
 static uint32_t pbl_crc32(uint32_t in_crc, const char *buf, uint32_t len)
 {
-	uint32_t crc32_val;
-	int i;
-
-	make_crc_table();
-
-	crc32_val = ~in_crc;
-
-	for (i = 0; i < len; i++)
-		crc32_val = (crc32_val << 8) ^
-			crc_table[(crc32_val >> 24) ^ (*buf++ & 0xff)];
-
-	return crc32_val;
+	return crc32_be(~in_crc, buf, len);
 }
 /*
  * AES libcrypto
-- 
2.39.2




More information about the barebox mailing list