[PATCH v2 6/7] mci: sdhci: Force DMA update to the next block boundary
Jules Maselbas
jmaselbas at kalray.eu
Wed Aug 16 02:39:44 PDT 2023
Signed-off-by: Jules Maselbas <jmaselbas at kalray.eu>
---
change in v2:
- applied the fixup:
straight copy from Linux didn't worked because the macro SDHCI_DMA_BOUNDARY_512K
(default value of sdhci::sdma_boundary) is not a size but the enum value to be
written in the transfer control register.
drivers/mci/sdhci.c | 14 +++++++++++++-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/drivers/mci/sdhci.c b/drivers/mci/sdhci.c
index 4aca3af5aa..b0b83bfaa9 100644
--- a/drivers/mci/sdhci.c
+++ b/drivers/mci/sdhci.c
@@ -279,8 +279,20 @@ int sdhci_transfer_data_dma(struct sdhci *sdhci, struct mci_data *data,
goto out;
}
+ /*
+ * We currently don't do anything fancy with DMA
+ * boundaries, but as we can't disable the feature
+ * we need to at least restart the transfer.
+ *
+ * According to the spec sdhci_readl(host, SDHCI_DMA_ADDRESS)
+ * should return a valid address to continue from, but as
+ * some controllers are faulty, don't trust them.
+ */
if (irqstat & SDHCI_INT_DMA) {
- u32 addr = sdhci_read32(sdhci, SDHCI_DMA_ADDRESS);
+ int boundary_cfg = (sdhci->sdma_boundary >> 12) & 0x7;
+ dma_addr_t boundary_size = 4096 << boundary_cfg;
+ /* Force update to the next DMA block boundary. */
+ dma = (dma & ~(boundary_size - 1)) + boundary_size;
/*
* DMA engine has stopped on buffer boundary. Acknowledge
--
2.41.0
More information about the barebox
mailing list