[PATCH] mci: arasan: Fix reg/val argument swap in register write

Sascha Hauer s.hauer at pengutronix.de
Wed Aug 2 23:59:50 PDT 2023

sdhci_write8() takes the register before the value. Fix the argument

The wrong code path is only taken when the xlnx,fails-without-test-cd
property exists which is not the case for any dts file in the tree, so
this bugfix shouldn't have any practical consequences.

Signed-off-by: Sascha Hauer <s.hauer at pengutronix.de>
 drivers/mci/arasan-sdhci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mci/arasan-sdhci.c b/drivers/mci/arasan-sdhci.c
index 71e974c384..8965acd442 100644
--- a/drivers/mci/arasan-sdhci.c
+++ b/drivers/mci/arasan-sdhci.c
@@ -84,7 +84,7 @@ static int arasan_sdhci_reset(struct arasan_sdhci_host *host, u8 mask)
 		ctrl = sdhci_read8(&host->sdhci, SDHCI_HOST_CONTROL);
-		sdhci_write8(&host->sdhci, ctrl, SDHCI_HOST_CONTROL);
+		sdhci_write8(&host->sdhci, SDHCI_HOST_CONTROL, ctrl);
 	return 0;

More information about the barebox mailing list