[PATCH 4/5] commands: gpio: add -d argument to set/get commands

Ahmad Fatoum a.fatoum at pengutronix.de
Thu Sep 29 02:50:20 PDT 2022


On 28.09.22 14:37, Enrico Scholz wrote:
> Ahmad Fatoum <a.fatoum at pengutronix.de> writes:
> 
>> For debugging, it can be useful to reference GPIOs relative to a
>> controller, e.g.:
>>
>>   gpio_direction_output -d gpio4 20 1
>>
>> -	if (argc < count)
>> +	if (optind < count)
>>  		return COMMAND_ERROR_USAGE;
> 
> This change seems to make '-d ...' mandatory.  E.g.
> 
> | :/ gpio_get_value 65
> | 
> | gpio_get_value - return value of a GPIO pin
> | 
> | Usage: gpio_get_value [-d CONTROLLER] GPIO

Seems I had the blinders on when I drafted this patch
series. Thanks for reporting and thanks Sascha for
the fixes.


> 
> 
> Enrico
> 


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



More information about the barebox mailing list