Broken ubifs-zstd

[Ahmad Fatoum]

Hello Enrico,

On 27.09.22 18:21, Enrico Scholz wrote:
> Hello,
> 
> trying to mount a zstd compressed ubifs fails on an iMX6ULL with
> 
> | ERROR: UBIFS error (ubi0:0): 9fe6691d: cannot decompress 2612 bytes, compressor zstd, error -22
> | ERROR: UBIFS error (ubi0:0): 9fe6692d: cannot decompress 2612 bytes, compressor zstd, error -22
> | ERROR: UBIFS error (ubi0:0): 9fe66a65: bad data node (block 0, inode 815)
> | ERROR:  magic          0x6101831
> 
> (2022.09 and master).
> 
> 
> After reverting
> 
> | commit b4a9782d4f56333e897dccc35c2c27e2605f6b93
> | Author: Ahmad Fatoum <a.fatoum at pengutronix.de>
> | Date:   Wed Jul 13 12:09:18 2022 +0200
> | 
> |     lib: zstd: sync with Linux
> 
> it works again (both in Linux 5.15 and barebox).
> 
> 
> ubifs was created by recent OpenEmbedded kirkstone with
> 
> | MKUBIFS_ARGS = "-F -m 2048 -e 126976 -c 2048 --compr=zstd"
> 
> 
> Warnings are triggered (after fixing assert()) at
> 
> | WARNING: at lib/zstd/decompress/../common/bitstream.h:390/BIT_reloadDStreamFast()!
> 
> 
> Is anybody else experiencing these problems?


I am afraid, I didn't properly test this with UBIFS..

> 
> 
> 
> Enrico
> 
> 


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |