[PATCH] tftp: allocate at least 4096 bytes for FIFO
Ahmad Fatoum
a.fatoum at pengutronix.de
Mon Sep 5 05:07:31 PDT 2022
Hello Enrico,
On 05.09.22 11:03, Enrico Scholz wrote:
> Ahmad Fatoum <a.fatoum at pengutronix.de> writes:
>
>> On one board, boots from /mnt/tftp currently fail for me with:
>>
>> ERROR: tftp: tftp: not enough room in kfifo (only 1376 out of 1432 written
>
> Thanks for noticing that; I sent fixups for the recent patchset.
Thanks for the prompt reply and series.
> Perhaps, can you test it on your failing platform with changing
>
> | #define TFTP_EXTRA_BLOCKS 2
>
> to
>
> | #define TFTP_EXTRA_BLOCKS 0
>
> ?
>
> This should turn off the workaround of over-allocating memory and isolate
> (and verify) the fix for the real problem.
Issue was not reproducible with TFTP_EXTRA_BLOCKS 0.
FWIW, the same barebox binary only had the issue when booting via USB network adapter
(DUB-E100) on one board, but not when booting from i.MX8MM FEC on another board.
Cheers,
Ahmad
>
>
>
> Enrico
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
More information about the barebox
mailing list