[PATCH 1/2] usb: host: ehci: add GENERIC_PHY dependency to Kconfig
Sascha Hauer
s.hauer at pengutronix.de
Thu Mar 3 01:55:14 PST 2022
Hi Denis,
On Tue, Mar 01, 2022 at 12:14:22PM +0300, Denis Orlov wrote:
> With GENERIC_PHY disabled, EHCI driver initialization fails in
> ehci_probe() as calling phy_optional_get() returns "Function not
> implemented" value. So it seems reasonable to make USB_EHCI explicitly
> depend on GENERIC_PHY.
>
> Signed-off-by: Denis Orlov <denorl2009 at gmail.com>
> ---
> drivers/usb/host/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
> index d38b4dcac4..cc71b76902 100644
> --- a/drivers/usb/host/Kconfig
> +++ b/drivers/usb/host/Kconfig
> @@ -2,6 +2,7 @@
> config USB_EHCI
> bool "EHCI driver"
> depends on HAS_DMA
> + depends on GENERIC_PHY
This effectively disables the EHCI in a bunch of defconfigs. I finally
decided for the other approach and made phy_optional_get() return NULL
when GENERIC_PHY is disabled. This should solve this problem.
Applied the other patch in the series.
Sascha
>
> config USB_EHCI_OMAP
> depends on ARCH_OMAP3
> --
> 2.20.1
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
More information about the barebox
mailing list