[PATCH 4/8] usb: gadget: Fix Kconfig dependencies

Ahmad Fatoum a.fatoum at pengutronix.de
Tue Jun 28 23:55:46 PDT 2022


Hello Sascha,

On 29.06.22 08:52, Sascha Hauer wrote:
> Without GLOBALVAR selected the USB gadget autostart stuff can be
> compiled, but without any functionality, as all functionality is
> behind globalvars, so adding this dependency mykes sense.
> 
>>  	select SYSTEM_PARTITIONS if USB_GADGET_MASS_STORAGE
> 
> I am not sure why SYSTEM_PARTITIONS is selected here. Maybe Ahmad can
> comment on that. From what I can see with USB_GADGET_AUTOSTART selected
> without SYSTEM_PARTITIONS we still get autostart functionality, but
> without global.system.partitions support which seems ok.

Instead of adding yet another gadget-specific global variable,
the mass storage gadget only uses system partitions, so this
select makes sense IMO.

Cheers,
Ahmad

> 
> Sascha
> 


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



More information about the barebox mailing list