[PATCH] i2c: add bcm283x i2c host controller support

[Ahmad Fatoum]

Hello Daniel,

Thanks for your patch.

On 11.06.22 23:28, Daniel Brát wrote:
> Add a driver to support the i2c host controller (BSC)
> found on bcm283x family os SoCs.

s/os/of/

> 
> Signed-off-by: Daniel Brát <danek.brat at gmail.com>
> ---
>  arch/arm/configs/rpi_v8a_defconfig |   3 +-

You can enable it for rpi_defconfig too

>  drivers/i2c/busses/Kconfig         |   4 +
>  drivers/i2c/busses/Makefile        |   1 +
>  drivers/i2c/busses/i2c-bcm283x.c   | 372 +++++++++++++++++++++++++++++
>  4 files changed, 379 insertions(+), 1 deletion(-)
>  create mode 100644 drivers/i2c/busses/i2c-bcm283x.c
> 
> diff --git a/arch/arm/configs/rpi_v8a_defconfig b/arch/arm/configs/rpi_v8a_defconfig
> index 68cd2438b..e218311a7 100644
> --- a/arch/arm/configs/rpi_v8a_defconfig
> +++ b/arch/arm/configs/rpi_v8a_defconfig
> @@ -81,6 +81,8 @@ CONFIG_SERIAL_AMBA_PL011=y
>  CONFIG_DRIVER_SERIAL_NS16550=y
>  CONFIG_NET_USB=y
>  CONFIG_NET_USB_SMSC95XX=y
> +CONFIG_I2C=y
> +CONFIG_I2C_BCM283X=y
>  CONFIG_USB_HOST=y
>  CONFIG_USB_DWC2_HOST=y
>  CONFIG_USB_DWC2_GADGET=y
> @@ -108,4 +110,3 @@ CONFIG_FS_FAT=y
>  CONFIG_FS_FAT_WRITE=y
>  CONFIG_FS_FAT_LFN=y
>  CONFIG_ZLIB=y
> -CONFIG_LZO_DECOMPRESS=y
> diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
> index 58f865606..429f5ba42 100644
> --- a/drivers/i2c/busses/Kconfig
> +++ b/drivers/i2c/busses/Kconfig
> @@ -17,6 +17,10 @@ config I2C_AT91
>  	bool "AT91 I2C Master driver"
>  	depends on ARCH_AT91
>  
> +config I2C_BCM283X
> +	bool "BCM283X I2C Master driver"
> +	depends on ARCH_BCM283X

|| COMPILE_TEST

> +			if (ret) {
> +				dev_err(dev, "timeout: 10bit addr "
> +					     "read initilization\n");

Don't line-break strings. It needlessly complicates searching for messages
in the code. Also you don't need to adhere religiously to 80 characters.
Up to 100 characters is usually ok. If you go beyond that, reevaluate
if it wouldn't be more readable to reduce indentation.

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |