[PATCH v3 2/2] fastboot: bail if update handler couldn't be found for bbu-partition

Ahmad Fatoum a.fatoum at pengutronix.de
Thu Jun 9 06:09:36 PDT 2022


Fastboot would fall back to a raw copy even for bbu- partitions if
no barebox_update handler was found. Prevent this by bailing out
with an error code.

Signed-off-by: Ahmad Fatoum <a.fatoum at pengutronix.de>
---
v2 -> v3:
  - bail out instead of only printing message and falling back
    to raw copy (Sascha)
v1 -> v2:
  - print message in case barebox_update handler is not found
---
 common/fastboot.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/common/fastboot.c b/common/fastboot.c
index 330a06f5a32f..a5cf04b39ecd 100644
--- a/common/fastboot.c
+++ b/common/fastboot.c
@@ -683,8 +683,13 @@ static void cb_flash(struct fastboot *fb, const char *cmd)
 		};
 
 		handler = bbu_find_handler_by_device(data.devicefile);
-		if (!handler)
-			goto copy;
+		if (!handler) {
+			fastboot_tx_print(fb, FASTBOOT_MSG_FAIL,
+					  "No barebox update handler registered for %s",
+					  data.devicefile);
+			ret = -ENOENT;
+			goto out;
+		}
 
 		fastboot_tx_print(fb, FASTBOOT_MSG_INFO,
 				  "This is a barebox image...");
-- 
2.30.2




More information about the barebox mailing list