Aw: Re: [PATCH v1] ARM: Rockchip: Add rk3568 BananaPi R2 Pro board support

Frank Wunderlich frank-w at public-files.de
Thu Feb 10 07:22:22 PST 2022


> Gesendet: Montag, 24. Januar 2022 um 09:55 Uhr
> Von: "Sascha Hauer" <s.hauer at pengutronix.de>

> I saw this device tree looks different from the one you sent for kernel
> inclusion. This is not a problem now, but once the kernel dts is
> upstream it will show up in dts/ in the barebox tree. We then usually
> include the upstream dts from the barebox board dts, so that only the
> barebox specific additions are in the barebox dts. Given that it would
> be nice if you could minimize the differences now already, so that later
> inclusion of the upstream dts becomes easier.

Hi,

after dts got merged to linux i used it to find differences and minimized them.

have not added io-domain as i don't know if they change in future and they are not needed in barebox.

needed to add tsadc+pinctrl and spi3 to rk3568*.dtsi as they are referenced in my linux board dts

can you look if the dts is now ok for upstreaming?

https://github.com/frank-w/barebox-r2pro/blob/r2pro/arch/arm/dts/rk3568-bpi-r2-pro.dts

regards Frank



More information about the barebox mailing list