[PATCH v4 06/21] tftp: minor refactoring of RRQ/WRQ packet generation code
Enrico Scholz
enrico.scholz at sigma-chemnitz.de
Tue Aug 30 00:38:01 PDT 2022
Having 11 printf arguments with lot of them being 0, makes it
difficulty to read and extend.
Add some comments and use '\0' for %c.
Signed-off-by: Enrico Scholz <enrico.scholz at sigma-chemnitz.de>
---
fs/tftp.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/fs/tftp.c b/fs/tftp.c
index c1a193711793..0b2a420b6639 100644
--- a/fs/tftp.c
+++ b/fs/tftp.c
@@ -134,11 +134,11 @@ static int tftp_send(struct file_priv *priv)
"%d%c"
"blksize%c"
"1432",
- priv->filename + 1, 0,
- 0,
- 0,
- TIMEOUT, 0,
- 0);
+ priv->filename + 1, '\0',
+ '\0', /* "octet" */
+ '\0', /* "timeout" */
+ TIMEOUT, '\0',
+ '\0'); /* "blksize" */
pkt++;
if (!priv->push)
--
2.37.2
More information about the barebox
mailing list