[PATCH 0/8] tftp fixups

Enrico Scholz enrico.scholz at sigma-chemnitz.de
Sun Aug 28 07:02:23 PDT 2022


The "tftp: allocate buffers and fifo dynamically" patch in the last
patchset broke interaction with non rfc 2347 servers (e.g. when data
transfer starts immediately after RRQ/WRQ without the OACK negotiation
phase).

This has been fixed for both RRQ and WRQ requests.

For WRQ requests (push), the "tsize" option will not be sent anymore
because it is always '0' and can confuse servers.

New patches add some sanity checks which prevent modification of
internal information (blocksize or port numbers) when OACK packets
arrive in the middle of a transfer.


Enrico Scholz (8):
  tftp: make debug_assert() critical when selftest is enabled.
  tftp: remove sanity check of first block
  tftp: split out allocation and cache initialization
  tftp: accept OACK + DATA datagrams only in certain states
  tftp: support non rfc 2347 servers
  tftp: do not set 'tsize' in wrq requests
  tftp: fix WRQ support
  tftp: add some documentation about windowsize support

 Documentation/filesystems/tftp.rst |  38 ++++++
 fs/tftp.c                          | 189 +++++++++++++++++++----------
 2 files changed, 166 insertions(+), 61 deletions(-)

-- 
2.37.2




More information about the barebox mailing list