[PATCH 9/9] i2c-mux-pca954x: drop duplicate warning message on probe

Ahmad Fatoum a.fatoum at pengutronix.de
Sat Oct 30 10:58:12 PDT 2021


Driver core will already print an error with the probe's return code,
so no need to print a less useful message before that.

Signed-off-by: Ahmad Fatoum <a.fatoum at pengutronix.de>
---
 drivers/i2c/muxes/i2c-mux-pca954x.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/i2c/muxes/i2c-mux-pca954x.c b/drivers/i2c/muxes/i2c-mux-pca954x.c
index 0d31804c1047..5aec9fdd5fa4 100644
--- a/drivers/i2c/muxes/i2c-mux-pca954x.c
+++ b/drivers/i2c/muxes/i2c-mux-pca954x.c
@@ -207,10 +207,8 @@ static int pca954x_probe(struct device_d *dev)
 	 * that the mux is in fact present. This also
 	 * initializes the mux to disconnected state.
 	 */
-	if (i2c_smbus_write_byte(client, 0) < 0) {
-		dev_warn(&client->dev, "probe failed\n");
+	if (i2c_smbus_write_byte(client, 0) < 0)
 		goto exit_free;
-	}
 
 	ret = dev_get_drvdata(dev, (const void **)&tmp);
 	data->type = tmp;
-- 
2.30.2




More information about the barebox mailing list