[PATCH] phy: core: Make 'phy_optional_get' return NULL when not implemented

Daniel Brát danek.brat at gmail.com
Wed Oct 20 01:39:54 PDT 2021


Make 'phy_optional_get' return NULL instead of ERR_PTR(-ENOSYS) when the
CONFIG_GENERIC_PHY is not enabled. It makes more sense to return NULL instead
of straight up throwing a error since the function has 'optional' in its name.
This also fixes dwc2 usb driver which would previously fail inside its probe
function despite being able to function without a phy just fine.

Signed-off-by: Daniel Brát <danek.brat at gmail.com>
---
 include/linux/phy/phy.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/phy/phy.h b/include/linux/phy/phy.h
index 679ce6e42..321e546f9 100644
--- a/include/linux/phy/phy.h
+++ b/include/linux/phy/phy.h
@@ -195,7 +195,7 @@ static inline struct phy *phy_get(struct device_d *dev, const char *string)
 static inline struct phy *phy_optional_get(struct device_d *dev,
 					   const char *string)
 {
-	return ERR_PTR(-ENOSYS);
+	return NULL;
 }
 
 static inline struct phy *of_phy_get_by_phandle(struct device_d *dev,
-- 
2.17.1




More information about the barebox mailing list