[PATCH v2 2/2] net: phy: micrel: sync init code for ksz80xx variants with the kernel driver

Trent Piepho trent.piepho at igorinstitute.com
Thu Oct 14 13:32:27 PDT 2021

On Wed, Oct 13, 2021 at 4:19 AM Oleksij Rempel <o.rempel at pengutronix.de> wrote:
> On Wed, Oct 13, 2021 at 03:25:17AM -0700, Trent Piepho wrote:
> > On Wed, Oct 13, 2021 at 2:43 AM Oleksij Rempel <o.rempel at pengutronix.de> wrote:
> > >
> > > Sync part of barebox micrel driver with the kernel v5.15-rc1.
> > > This change will affect most of by barebox supported 100Mbit/ksz80xx PHY
> > > variants and provide unified devicetree support for LED and clock configuration.
> >
> > I already added LED mode OF support to this driver.
> Yes, it was partially incorrect. It attempted to write to not existing or not
> documented register of PHY_ID_KS8737.

That is not true.  KS8737 would only attempt to set the led mode bits
if the device tree tries to set the led mode.  Since KS8737 does not
have a led mode selection, the device tree should not have this, and
there is no problem.

If you want a device tree validator, then use the yaml dts spec to do
this in the proper way, at build time.  The bootloader has the the
most constrained size of any part of a Linux system and is also the
most critical for device start up time.  It is the worst possible
place to put a dts validator.

> This is the reason why I prefer to share driver code base with kernel,
> where possible.

You again ignore there are two ways to do this.  Make the kernel match
Barebox where the Barebox code is better.

More information about the barebox mailing list