[PATCH 6/9] usb: dwc3: Clarify error message

[Trent Piepho]

On Mon, Oct 11, 2021 at 1:04 AM Sascha Hauer <s.hauer at pengutronix.de> wrote:
>         case DWC3_GHWPARAMS0_MODE_GADGET:
>                 if (IS_ENABLED(CONFIG_USB_DWC3_HOST)) {
>                         dev_err(dev,
> -                               "Controller does not support host mode.\n");
> +                               "This barebox does not support DWC3 host mode.\n");

Aren't these messages backward?  The hardware is set to device mode,
CONFIG_USB_DWC3_HOST means, "Support only host mode," so it should
fail because Barebox does not support device mode.

Maybe something like: "Barebox built without support for DWC3 USB
device mode (USB_DWC_HOST).\n"  Let the person know what variable to
search for in the config menu to change it.

>                         return -EINVAL;
>                 }
>                 mode = USB_DR_MODE_PERIPHERAL;
> @@ -51,7 +51,7 @@ static int dwc3_get_dr_mode(struct dwc3 *dwc)
>         case DWC3_GHWPARAMS0_MODE_HOST:
>                 if (IS_ENABLED(CONFIG_USB_DWC3_GADGET)) {
>                         dev_err(dev,
> -                               "Controller does not support device mode.\n");
> +                               "This barebox does not support DWC3 device mode.\n");
>                         return -EINVAL;
>                 }
>                 mode = USB_DR_MODE_HOST;