[PATCH] ARM: socfpga: Set reset-names property for &mmc

Ian Abbott abbotti at mev.co.uk
Mon Nov 1 10:40:53 PDT 2021

Since commit 90bdf1e5d1e4 ("mci: dw_mmc: match against StarFive MMC
compatibles"), the dw_mmc driver requires a reset line called "reset".
The slightly earlier commit a3cf324593ea ("mci: dw_mmc: add optional
reset line") introduced the reset line support, but made it optional.

The device tree node for SoCFPGA's MMC device has the "resets" property,
but is missing the "reset-names" property, so MMC no longer works.
Barebox produces the error message:

ERROR: dw_mmc ff704000.dwmmc0 at ff704000.of: probe failed: Invalid argument

Add the missing "reset-names" property to the "&mmc" node in
"arch/arm/dts/socfpga.dtsi".  It probably needs fixing in the upstream
Linux device tree sources too!

Cc: Ahmad Fatoum <a.fatoum at pengutronix.de>
Cc: Steffen Trumtrar <s.trumtrar at pengutronix.de>
Signed-off-by: Ian Abbott <abbotti at mev.co.uk>
 arch/arm/dts/socfpga.dtsi | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm/dts/socfpga.dtsi b/arch/arm/dts/socfpga.dtsi
index 7789c9d3b5..56dbf0b97d 100644
--- a/arch/arm/dts/socfpga.dtsi
+++ b/arch/arm/dts/socfpga.dtsi
@@ -4,6 +4,10 @@
+&mmc {
+	reset-names = "reset";
 &watchdog0 {
 	resets = <&rst L4WD0_RESET>;

More information about the barebox mailing list