[PATCH 3/7] net: phy: dp83867: remove useless call to genphy_config_aneg

Michael Tretter m.tretter at pengutronix.de
Fri Mar 19 13:10:12 GMT 2021


genphy_config_aneg will be called by the generic code anyway. No need to
call it from the driver.

As at it, do not explicitly set the config_aneg and read_status
pointers, because they will be automatically set anyway.

Remove the "hello world" message by the driver, too.

Signed-off-by: Michael Tretter <m.tretter at pengutronix.de>
---
 drivers/net/phy/dp83867.c | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/drivers/net/phy/dp83867.c b/drivers/net/phy/dp83867.c
index deee7e3ae7ca..8a14927071b9 100644
--- a/drivers/net/phy/dp83867.c
+++ b/drivers/net/phy/dp83867.c
@@ -278,13 +278,9 @@ static int dp83867_config_init(struct phy_device *phydev)
 		}
 	}
 
-	genphy_config_aneg(phydev);
-
 	if (dp83867->port_mirroring != DP83867_PORT_MIRROING_KEEP)
 		dp83867_config_port_mirroring(phydev);
 
-	dev_info(&phydev->dev, "DP83867\n");
-
 	return 0;
 }
 
@@ -294,11 +290,7 @@ static struct phy_driver dp83867_driver[] = {
 		.phy_id_mask = 0xfffffff0,
 		.drv.name = "TI DP83867",
 		.features = PHY_GBIT_FEATURES,
-
 		.config_init = dp83867_config_init,
-
-		.config_aneg = genphy_config_aneg,
-		.read_status = genphy_read_status,
 	},
 };
 
-- 
2.29.2




More information about the barebox mailing list