[RFC PATCH] reset: Remove WARN_ON when CONFIG_RESET_CONTROLLER=n
Jules Maselbas
jmaselbas at kalray.eu
Fri Mar 12 15:21:45 GMT 2021
Signed-off-by: Jules Maselbas <jmaselbas at kalray.eu>
---
I am using dwc2 but my platform doesn't has CONFIG_RESET_CONTROLLER enabled,
when booting barebox I got this kind of message:
WARNING: at barebox/include/linux/reset.h:54/device_reset_us()!
Not sure if removing all the WARN_ON is a good idea... asking for insight.
---
include/linux/reset.h | 7 -------
1 file changed, 7 deletions(-)
diff --git a/include/linux/reset.h b/include/linux/reset.h
index 4a92a177b..a166fe1cf 100644
--- a/include/linux/reset.h
+++ b/include/linux/reset.h
@@ -21,43 +21,36 @@ int __must_check device_reset_us(struct device_d *dev, int us);
static inline int reset_control_reset(struct reset_control *rstc)
{
- WARN_ON(1);
return 0;
}
static inline int reset_control_assert(struct reset_control *rstc)
{
- WARN_ON(1);
return 0;
}
static inline int reset_control_deassert(struct reset_control *rstc)
{
- WARN_ON(1);
return 0;
}
static inline struct reset_control *
reset_control_get(struct device_d *dev, const char *id)
{
- WARN_ON(1);
return NULL;
}
static inline void reset_control_put(struct reset_control *rstc)
{
- WARN_ON(1);
}
static inline int device_reset_us(struct device_d *dev, int us)
{
- WARN_ON(1);
return 0;
}
static inline int device_reset(struct device_d *dev)
{
- WARN_ON(1);
return 0;
}
--
2.17.1
More information about the barebox
mailing list