[PATCH] usb: usb251xb: remove >=0 check for u32 port

Sascha Hauer sha at pengutronix.de
Sun Jun 20 21:34:23 PDT 2021


On Thu, Jun 17, 2021 at 07:00:19PM +0200, Rouven Czerwinski wrote:
> The compiler rightfully complains:
> 
>   drivers/usb/misc/usb251xb.c: In function ‘usb251xb_get_ofdata’:
>   drivers/usb/misc/usb251xb.c:563:13: warning: comparison of unsigned expression in ‘>= 0’ is always true [-Wtype-limits]
>     563 |   if ((port >= 0) && (port <= data->port_cnt))
> 
> so drop the check.
> 
> Signed-off-by: Rouven Czerwinski <r.czerwinski at pengutronix.de>
> ---
>  drivers/usb/misc/usb251xb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



More information about the barebox mailing list