[PATCH 3/7] dma: apbh: fix out-of-bounds write on 64-bit SoCs
Ahmad Fatoum
a.fatoum at pengutronix.de
Mon Sep 28 11:42:43 EDT 2020
i.MX8 MM & MN are both ARM64 SoCs with a device compatible
with "fsl,imx28-dma-apbh". Probing the barebox device driver on these
SoCs would invoke undefined behavior however, because of an
errant cast. Fix this.
This has a side-effect: Whereas before, probing devices matched by
driver name failed with -ENODEV, they are now considered to be
compatible to IMX23_DMA instead. As we don't depend on this, this
is deemed acceptable.
Signed-off-by: Ahmad Fatoum <a.fatoum at pengutronix.de>
---
drivers/dma/apbh_dma.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/dma/apbh_dma.c b/drivers/dma/apbh_dma.c
index 3bee89f78b85..186c69388c7f 100644
--- a/drivers/dma/apbh_dma.c
+++ b/drivers/dma/apbh_dma.c
@@ -596,9 +596,7 @@ static int apbh_dma_probe(struct device_d *dev)
enum mxs_dma_id id;
int ret, channel;
- ret = dev_get_drvdata(dev, (const void **)&id);
- if (ret)
- return ret;
+ id = (enum mxs_dma_id)device_get_match_data(dev);
apbh_dma = apbh = xzalloc(sizeof(*apbh));
iores = dev_request_mem_resource(dev, 0);
--
2.28.0
More information about the barebox
mailing list