[PATCH 2/4] fs: Drop unnecessary dput()

Sascha Hauer s.hauer at pengutronix.de
Mon Sep 14 09:06:38 EDT 2020


Calling dput() on the root dentry during unmount time is unnecessary,
the dentry will be removed later in dentry_delete_subtree() anyway.

Signed-off-by: Sascha Hauer <s.hauer at pengutronix.de>
---
 fs/fs.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/fs/fs.c b/fs/fs.c
index 30b835e265..a6c6f0cc93 100644
--- a/fs/fs.c
+++ b/fs/fs.c
@@ -667,7 +667,6 @@ static void fs_remove(struct device_d *dev)
 	if (fsdev->loop && fsdev->cdev)
 		cdev_remove_loop(fsdev->cdev);
 
-	dput(sb->s_root);
 	dentry_delete_subtree(sb, sb->s_root);
 
 	list_for_each_entry_safe(inode, tmp, &sb->s_inodes, i_sb_list)
-- 
2.28.0




More information about the barebox mailing list