[PATCH 1/4] aiodev: Name channels with device instance name

Trent Piepho trent.piepho at synapse.com
Wed Sep 9 15:36:47 EDT 2020


When dynamically assigning device names, an aiodev's name will be
"aiodev" and an index, not part of the name string itself, will be
allocated dynamically.  These are combined to register a device with a
name like "aiodev0" or "aiodev1".

The shell environment variables use the device name, so one might use
"${aiodev0.in_value0_mV}" and "${aiodev1.in_value0_mV}".

However, the channel names that are used with aiochannel_get_by_name()
just use the aiodev's name and channel name.  So channel 0 of the 1st
aiodev would be "aiodev.in_value0_mV" and the 2nd aiodev would use the
same name.

Change the channel naming to use the device instance name, e.g.
"aiodev0", rather than the aiodev's base name.  This makes the names
used aiochannel_get_by_name() match the environment variable names and
also avoids duplicate names with more than one dynamically allocated
aiodev.

Signed-off-by: Trent Piepho <trent.piepho at synapse.com>
---
 drivers/aiodev/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/aiodev/core.c b/drivers/aiodev/core.c
index b8428346a..7d9170d2d 100644
--- a/drivers/aiodev/core.c
+++ b/drivers/aiodev/core.c
@@ -131,7 +131,7 @@ int aiodevice_register(struct aiodevice *aiodev)
 				  aiochannel_param_get_value,
 				  &aiochan->value, "%d", aiochan);
 
-		aiochan->name = xasprintf("%s.%s", aiodev->name, name);
+		aiochan->name = xasprintf("%s.%s", dev_name(&aiodev->dev), name);
 
 		free(name);
 	}
-- 
2.25.4




More information about the barebox mailing list