[PATCH 2/2] x86/config/efi: drop DRIVER_SERIAL_NS16550

Ahmad Fatoum a.fatoum at pengutronix.de
Tue Oct 20 01:08:47 EDT 2020


Hello Uwe,

On 9/18/20 1:04 PM, Uwe Kleine-König wrote:
> For most machines having DRIVER_SERIAL_NS16550 and DRIVER_SERIAL_EFI_STDIO
> both enabled results in the output appearing twice on the serial output.
> So remove disable the lowlevel driver and rely on the EFI bios for serial.

On the flip-side, some systems now won't output anything over serial with
the defconfig, like the one I just ran into. Maybe we should keep both
enabled, but have a quirk table, which boards to disable the 16550 for?

My board is
  EFI v2.40 by American Megatrends v327691". What's yours?
  barebox at barebox EFI payload:/ devinfo acpi-FACP0
  [...]
  Revision: 5
  OemId: ALASKA
  OemTableId: A M I
  OemRevision: 17244169
  CreatorId: 0x20494d41
  CreatorRevision: 65555

What's yours?
 
Cheers,
Ahmad

 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
> ---
>  arch/x86/configs/efi_defconfig | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/x86/configs/efi_defconfig b/arch/x86/configs/efi_defconfig
> index 99bc39eaa6f1..83794d7a0702 100644
> --- a/arch/x86/configs/efi_defconfig
> +++ b/arch/x86/configs/efi_defconfig
> @@ -65,7 +65,6 @@ CONFIG_NET=y
>  CONFIG_NET_NFS=y
>  CONFIG_NET_NETCONSOLE=y
>  CONFIG_DRIVER_SERIAL_EFI_STDIO=y
> -CONFIG_DRIVER_SERIAL_NS16550=y
>  CONFIG_DRIVER_NET_EFI_SNP=y
>  # CONFIG_SPI is not set
>  CONFIG_DISK=y
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



More information about the barebox mailing list