[PATCH 1/4] hush: remove non-functional code

[Sascha Hauer]

On Thu, Nov 26, 2020 at 07:31:51PM +0100, Ahmad Fatoum wrote:
> name is unused except for printing and value is modified, but never read
> back. They currently serve no purpose, so drop them. The actual
> splitting by '=' happens in set_local_var later.
> 
> Signed-off-by: Ahmad Fatoum <ahmad at a3f.at>
> ---
>  common/hush.c | 9 +--------
>  1 file changed, 1 insertion(+), 8 deletions(-)

Applied, thanks

Sascha

> 
> diff --git a/common/hush.c b/common/hush.c
> index ec0d5129b70d..a6fc4485bf52 100644
> --- a/common/hush.c
> +++ b/common/hush.c
> @@ -798,16 +798,9 @@ static int run_pipe_real(struct p_context *ctx, struct pipe *pi)
>  			 * This junk is all to decide whether or not to export this
>  			 * variable. */
>  			int export_me = 0;
> -			char *name, *value;
>  
> -			name = xstrdup(child->argv[i]);
> -			hush_debug("Local environment set: %s\n", name);
> -			value = strchr(name, '=');
> +			hush_debug("Local environment set: %s\n", child->argv[i]);
>  
> -			if (value)
> -				*value = 0;
> -
> -			free(name);
>  			p = insert_var_value(child->argv[i]);
>  			rcode = set_local_var(p, export_me);
>  			if (rcode)
> -- 
> 2.28.0
> 
> 
> _______________________________________________
> barebox mailing list
> barebox at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |