[PATCH] arm: baltos: add environment node

[Sascha Hauer]

Hi Yegor,

On Tue, Jul 14, 2020 at 07:13:28AM +0200, yegorslists at googlemail.com wrote:
> From: Yegor Yefremov <yegorslists at googlemail.com>
> 
> Use the second SPL partition in NAND for environment storage.
> 
> Signed-off-by: Yegor Yefremov <yegorslists at googlemail.com>
> ---
>  arch/arm/dts/am335x-baltos-minimal.dts | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/dts/am335x-baltos-minimal.dts b/arch/arm/dts/am335x-baltos-minimal.dts
> index 137c177b2..8dfad3eb0 100644
> --- a/arch/arm/dts/am335x-baltos-minimal.dts
> +++ b/arch/arm/dts/am335x-baltos-minimal.dts
> @@ -22,6 +22,11 @@
>  
>  	chosen {
>  		stdout-path = &uart0;
> +
> +		environment-nand {
> +			compatible = "barebox,environment";
> +			device-path = &nand, "partname:SPL.backup1";
> +		};

Please add a phandle to the partition directly rather than to the NAND
device containing it.

When this is used as environment partition, shouldn't it be renamed
accordingly? In case the ROM needs one of the SPL backups, does it cope
with the environment being in SPL.backup1? Otherwise I would suggest
using SPL.backup3 for the environment.

Regards,
  Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |