[PATCH 17/21] fastboot net: implement fastboot over UDP
Sascha Hauer
s.hauer at pengutronix.de
Sat Jul 11 00:48:17 EDT 2020
Hi Daniel,
On Mon, Jun 29, 2020 at 09:50:51PM +0200, Daniel Glöckner wrote:
> Hello Sascha,
>
> > +{
> > + struct fastboot_net *fbn = container_of(poller, struct fastboot_net,
> > + poller);
> > +
> > + if (fbn->active_download && is_timeout(fbn->last_download_pkt, 5 * SECOND)) {
>
> Should pollers prefer is_timeout_non_interruptible over is_timeout?
>
> I can make a new patch set where all issues are fixed, if you don't insist
> on doing it yourself.
Should have read this mail up to the end. I was about to tell you that I
won't find time in the next weeks to fix your valid review points, so
indeed I'd be happy if you could do this.
Regards,
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
More information about the barebox
mailing list