[PATCH] MIPS: use anonymous labels in ENTRY_FUNCTION_END and STOP_WITH_DEBUG_EVENT macros

Oleksij Rempel o.rempel at pengutronix.de
Wed Jun 5 21:29:10 PDT 2019


On Wed, Jun 05, 2019 at 09:38:17PM +0300, Peter Mamonov wrote:
> On Wed, Jun 05, 2019 at 07:17:03AM +0200, Oleksij Rempel wrote:
> > On Tue, Jun 04, 2019 at 07:43:12PM +0300, Peter Mamonov wrote:
> > > Hi, Oleksij,
> > > 
> > > On Tue, Jun 04, 2019 at 02:44:57PM +0200, Oleksij Rempel wrote:
> > > > On Tue, Jun 04, 2019 at 01:55:52PM +0300, Peter Mamonov wrote:
> > > > > Use of global labels of the same name inside ENTRY_FUNCTION_END and
> > > > > STOP_WITH_DEBUG_EVENT prevents simultaneous use of both macros. It also
> > > > > prevents multiple use of one of them.
> > > > 
> > > > Reviewed-by: Oleksij Rempel <o.rempel at pengutronix.de>
> > > > 
> > > > @Peter, Do you use STOP_WITH_DEBUG_EVENT for something?
> > > 
> > > Actually no. I hit this problem when tried to use ENTRY_FUNCTION_END twice to 
> > > choose relevant DTB depending on some conditions.
> > 
> > was you able to implement it?
> 
> Yes, something like this:
> 
> 		<test a condition, put result into t0>
> 
> 		beq	t0, zero, use_other_dtb
> 		 nop
> 
> 		ENTRY_FUNCTION_END(BOARD_PBL_START, some_dtb)
> 
> 	use_other_dtb:
> 		ENTRY_FUNCTION_END(BOARD_PBL_START, other_dtb)

nice!

Do you use latest barebox with dynamic relocation support?

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



More information about the barebox mailing list