[PATCH RFC] ARM: imx8: fix discrepancy between comment and code

Sascha Hauer s.hauer at pengutronix.de
Mon Jun 3 23:51:17 PDT 2019


On Fri, May 31, 2019 at 09:41:02AM +0200, Ahmad Fatoum wrote:
> The comment speaks of a one second polling timeout, while the polling
> is indefinite with timeout not accounted for. Thus change the comment
> to reflect the actual behavior.
> 
> Signed-off-by: Ahmad Fatoum <a.fatoum at pengutronix.de>
> ---
>  arch/arm/mach-imx/imx8-ddrc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Applied, thanks

Sascha

> 
> diff --git a/arch/arm/mach-imx/imx8-ddrc.c b/arch/arm/mach-imx/imx8-ddrc.c
> index 18454a91533b..736865eb6f12 100644
> --- a/arch/arm/mach-imx/imx8-ddrc.c
> +++ b/arch/arm/mach-imx/imx8-ddrc.c
> @@ -29,7 +29,7 @@ static u32 ddrc_phy_get_message(void __iomem *phy, int type)
>  
>  	/*
>  	 * When BIT0 set to 0, the PMU has a message for the user
> -	 * 10ms seems not enough for poll message, so use 1s here.
> +	 * Wait for it indefinitely.
>  	 */
>  	readl_poll_timeout(phy + DDRC_PHY_REG(0xd0004),
>  			   r, !(r & BIT(0)), 0);
> @@ -104,4 +104,4 @@ void ddrc_phy_wait_training_complete(void __iomem *phy)
>  		putc_ll('\r');
>  		putc_ll('\n');
>  	}
> -}
> \ No newline at end of file
> +}
> -- 
> 2.20.1
> 
> 
> _______________________________________________
> barebox mailing list
> barebox at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



More information about the barebox mailing list