mtd_peb_write broken on dataflash

Ladislav Michl ladis at linux-mips.org
Thu Sep 20 11:27:01 PDT 2018


As mtd_peb_write checks for alignment, it fails writing to dataflash:
barebox$ state -s
ERROR: state: Failed to write PEB 0, -22
ERROR: state: Failed to write circular to 0 length 48, -22
WARNING: state: Failed to write state backend bucket, -22
ERROR: state: Failed to write PEB 1, -22
ERROR: state: Failed to write circular to 0 length 48, -22
WARNING: state: Failed to write state backend bucket, -22
ERROR: state: Failed to write PEB 2, -22
ERROR: state: Failed to write circular to 0 length 48, -22
WARNING: state: Failed to write state backend bucket, -22
ERROR: state: Failed to write state to at least 1 buckets. Successfully written to 0 buckets
ERROR: state: Failed to write packed state, -5
state: I/O error

Patch bellow is a naive fix just to show where problem is.

There's also problem erasing dataflash:
barebox$ erase /dev/dataflash0.barebox-state
erase: Invalid argument

I guess we'll run into similar issue for MTD_RAM, so question is whenever
we want such a strict check here at all. Opinions?

Thank you.

---
 drivers/mtd/peb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mtd/peb.c b/drivers/mtd/peb.c
index c35b63f2f..6035fbc45 100644
--- a/drivers/mtd/peb.c
+++ b/drivers/mtd/peb.c
@@ -376,7 +376,7 @@ int mtd_peb_write(struct mtd_info *mtd, const void *buf, int pnum, int offset,
 		return -EINVAL;
 	if (len <= 0)
 		return -EINVAL;
-	if (len % (mtd->writesize >> mtd->subpage_sft))
+	if (mtd->type != MTD_DATAFLASH && len % (mtd->writesize >> mtd->subpage_sft))
 		return -EINVAL;
 	if (mtd_peb_is_bad(mtd, pnum))
 		return -EINVAL;
-- 
2.19.0




More information about the barebox mailing list