[PATCH 6/8] ARM: nxp-imx8mq-evk: Add FEC's PHY configuration code

Andrey Smirnov andrew.smirnov at gmail.com
Wed Sep 19 07:57:38 PDT 2018


On Wed, Sep 19, 2018 at 12:48 AM Sascha Hauer <s.hauer at pengutronix.de> wrote:
>
> On Mon, Sep 17, 2018 at 10:41:46PM -0700, Andrey Smirnov wrote:
> > Add appropriate DT node and a fixup routine needed for i.MX8MQ EVK
> > board.
> >
> > diff --git a/arch/arm/dts/imx8mq-evk.dts b/arch/arm/dts/imx8mq-evk.dts
> > index 3ac13baa1..bdc340a8b 100644
> > --- a/arch/arm/dts/imx8mq-evk.dts
> > +++ b/arch/arm/dts/imx8mq-evk.dts
> > @@ -43,7 +43,18 @@
> >                   <&pinctrl_fec1_data_tx>, <&pinctrl_fec1_data_rx>,
> >                   <&pinctrl_fec1_phy_reset>;
> >       phy-mode = "rgmii-id";
> > +     phy-handle = <&fec_phy>;
> > +     phy-reset-gpios = <&gpio1 9 GPIO_ACTIVE_LOW>;
> >       status = "okay";
> > +
> > +     mdio {
> > +             #address-cells = <1>;
> > +             #size-cells = <0>;
> > +
> > +             fec_phy: ethernet-phy at 1 {
> > +                     reg = <1>;
> > +             };
> > +     };
>
> What's the reason for adding a phy node here? It shouldn't be needed.
>

Yeah, I think I added it mistakenly thinking it was needed and never
re-check the correctness of that assumption. Will remove in v2.

Thanks,
Andrey Smirnov



More information about the barebox mailing list