[PATCH 1/4] pinctrl: imx-iomux-v3: fix compiler warning

Sam Ravnborg sam at ravnborg.org
Sun Sep 2 21:46:57 PDT 2018


Hi Roland.

On Sun, Sep 02, 2018 at 11:21:20PM +0200, Roland Hieber wrote:
> From: Roland Hieber <rohieb at rohieb.name>
> 
> Fix a warning while compiling with GCC 5.4.0 (OSELAS.Toolchain 2016.02):
> 
>     drivers/pinctrl/imx-iomux-v3.c: In function 'imx_iomux_v3_set_state':
>     drivers/pinctrl/imx-iomux-v3.c:153:13: warning: 'share_conf_val' may be used uninitialized in this function [-Wmaybe-uninitialized]
>         conf_val &= ~IMX_PAD_SION;
>                  ^
> The relevant code section at line 153 is:
> 
> 148:		u32 conf_val = share_conf ?
> 149:			share_conf_val : be32_to_cpu(*list++);
> 150:
> 151:		if (conf_val & IMX_PAD_SION) {
> 152:			mux_val |= IOMUXC_CONFIG_SION;
> 153:			conf_val &= ~IMX_PAD_SION;
> 154:		}

In this code snip we only see that share_conf_val is used (line 149),
it is not assigned.
So we do not really see the context of your message in the code snip.

	Sam



More information about the barebox mailing list