[PATCH v2 6/6] watchdog: add watchdog poller

[Sascha Hauer]

On Tue, Mar 13, 2018 at 09:33:28AM +0100, Oleksij Rempel wrote:
> In some cases it is practical to supervise as much as possible of
> the barebox execution with a watchdog (or multiple watchdogs). This
> patch provides an async poller for watchdog core framework which can
> be enabled by the user and stores this configuration to nv.
> 
> +static int watchdog_register_poller(struct watchdog *wd)
> +{
> +	struct param_d *p;
> +	int ret;
> +
> +	ret = poller_async_register(&wd->poller);
> +	if (ret)
> +		return ret;
> +
> +	p = dev_add_param_bool(&wd->dev, "poller_enable", watchdog_set_poller,
> +			NULL, &wd->poller_enable, wd);

The series looks mostly good and I applied 1-5. However, as Jan
mentioned we should find a better name for the variable. "poller_enable"
describes how it's internally implemented, not what this variable is
good for.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |