[PATCH 2/9] mfd: da9063: added generic reg_update() function

Sascha Hauer s.hauer at pengutronix.de
Thu Apr 12 00:22:24 PDT 2018


From: Enrico Scholz <enrico.scholz at sigma-chemnitz.de>

Used to set or clear bits of a register.

The calculation of 'client' might look odd and unnecessary complicated.
But style prepares access to other register banks which is added in
following patches.

Signed-off-by: Enrico Scholz <enrico.scholz at sigma-chemnitz.de>
Tested-by: Stefan Christ <s.christ at phytec.de>
Signed-off-by: Christian Hemp <c.hemp at phytec.de>
---
 drivers/mfd/da9063.c | 37 +++++++++++++++++++++++++++++++++++++
 1 file changed, 37 insertions(+)

diff --git a/drivers/mfd/da9063.c b/drivers/mfd/da9063.c
index 74ad5bfdab..68b0723b61 100644
--- a/drivers/mfd/da9063.c
+++ b/drivers/mfd/da9063.c
@@ -52,6 +52,43 @@ struct da9063 {
 #define DA9063_WATCHDOG		0x01
 #define DA9063_SHUTDOWN		0x02
 
+static int da906x_reg_update(struct da9063 *priv, unsigned int reg,
+			     uint8_t mask, uint8_t val)
+{
+	struct i2c_client *client;
+	uint8_t tmp;
+	int ret;
+
+	if (reg < 0x100)
+		client = priv->client;
+	else
+		/* this should/can not happen because function is usually
+		 * called with a static register number; warn about it
+		 * below */
+		client = NULL;
+
+	if (WARN_ON(!client))
+		return -EINVAL;
+
+	ret = i2c_read_reg(client, reg & 0xffu, &tmp, 1);
+	if (ret < 0) {
+		dev_warn(priv->dev, "failed to read reg %02x\n", reg);
+		return ret;
+	}
+
+	tmp &= ~mask;
+	tmp |= val;
+
+	ret = i2c_write_reg(client, reg & 0xffu, &tmp, 1);
+	if (ret < 0) {
+		dev_warn(priv->dev, "failed to write %02x into reg %02x\n",
+			 tmp, reg);
+		return ret;
+	}
+
+	return 0;
+}
+
 static int da9063_watchdog_ping(struct da9063 *priv)
 {
 	int ret;
-- 
2.16.1




More information about the barebox mailing list