[PATCH 1/5] commands: nv: argc cannot be < 1

[Enrico Joerns]

On 09/14/2017 08:27 AM, Sascha Hauer wrote:
> On Wed, Sep 13, 2017 at 02:23:28PM +0200, Enrico Jorns wrote:
>> argc == 1 will only contain the name of the program itself which must be
>> present when invoking nv command code.
> 
> This reasoning is not quite right. You miss the argc -= optind above the
> argc < 1 test. In fact in patch 4/5 you re-add the same test again
> (written as argc == 0 this time).
> 
> Shouldn't this patch simply be merged with 4/5?

In fact, you're right. Seems as if I splitted up changes a bit too much 
and confused myself. Merging it with 4/5 sound more reasonable (or 
simply drop both of them).

Enrico

-- 
Pengutronix e.K.                           | Enrico Jörns                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-5080 |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |