[PATCH] phy: don't crush if we have no parent
Sascha Hauer
s.hauer at pengutronix.de
Wed Sep 6 04:59:28 PDT 2017
On Sun, Aug 27, 2017 at 08:52:00AM +0200, Oleksij Rempel wrote:
> current code will crash if DT has no PHY entry. With this patch
> we will test if parent exist, before testing the parent device node.
>
> Signed-off-by: Oleksij Rempel <linux at rempel-privat.de>
> ---
> drivers/net/phy/phy.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks
Sascha
>
> diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c
> index 7132516aa..25ae40233 100644
> --- a/drivers/net/phy/phy.c
> +++ b/drivers/net/phy/phy.c
> @@ -323,7 +323,7 @@ static struct phy_device *of_mdio_find_phy(struct eth_device *edev)
> if (!IS_ENABLED(CONFIG_OFDEVICE))
> return NULL;
>
> - if (!edev->parent->device_node)
> + if (!edev->parent || !edev->parent->device_node)
> return NULL;
>
> phy_node = of_parse_phandle(edev->parent->device_node, "phy-handle", 0);
> --
> 2.11.0
>
>
> _______________________________________________
> barebox mailing list
> barebox at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
More information about the barebox
mailing list