[PATCH 03/10] lib: implement simple_strtoll

[Sascha Hauer]

On Mon, Apr 10, 2017 at 02:44:48PM +0200, Sam Ravnborg wrote:
> Hi Sascha.
> 
> Nitpick mode...
> 
> > --- a/lib/strtox.c
> > +++ b/lib/strtox.c
> > @@ -65,3 +65,11 @@ unsigned long long simple_strtoull (const char *cp, char **endp, unsigned int ba
> >  	return result;
> >  }
> >  EXPORT_SYMBOL(simple_strtoull);
> > +
> > +long long simple_strtoll(const char *cp,char **endp,unsigned int base)
> > +{
> > +	if(*cp=='-')
> 
> It hurts my eyes to see the missing space between if  and "(".

You're right. The whitespace placing throughout the file doesn't help
reading it. I just sent a patch cleaning it up and also fixed the
whitespaces in this patch.

> And on top I did not see simple_strtoull() used in the patch series.
> But then I may have missed it as I just skimmed the patches.

I'm pretty sure it's used ;)

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |