[PATCH v3 3/3] ARM: socfpga: dtsi: add dw-wdt reset lines
Sascha Hauer
s.hauer at pengutronix.de
Fri Oct 28 00:20:25 PDT 2016
On Thu, Oct 27, 2016 at 08:58:56AM +0200, Steffen Trumtrar wrote:
> On Wed, Oct 26, 2016 at 08:12:07PM +0000, Trent Piepho wrote:
> > On Mon, 2016-10-17 at 09:50 +0200, Steffen Trumtrar wrote:
> > > Signed-off-by: Steffen Trumtrar <s.trumtrar at pengutronix.de>
> > > ---
> > > arch/arm/dts/socfpga.dtsi | 10 ++++++++++
> > > 1 file changed, 10 insertions(+)
> > >
> > > diff --git a/arch/arm/dts/socfpga.dtsi b/arch/arm/dts/socfpga.dtsi
> > > index d16758fdab46..66d7f21dc6a3 100644
> > > --- a/arch/arm/dts/socfpga.dtsi
> > > +++ b/arch/arm/dts/socfpga.dtsi
> > > @@ -49,3 +49,13 @@
> > > &f2s_sdram_ref_clk {
> > > clock-frequency = <0>;
> > > };
> > > +
> > > +&watchdog0 {
> > > + resets = <&rst L4WD0_RESET>;
> > > + reset-names = "dw-wdt";
> >
> > This is the official binding? The reset-names property is supposed to
> > be the name of the reset from the perspective of the device being
> > described, e.g. the watchdog. Not the name from the perspective of the
> > reset controller. Rather than "dw-wdt", the name should something like
> > "reset", which clearly doesn't add much information, which is why the
> > reset-names property is supposed to be optional.
> >
>
> There is no "official" binding. I wasn't really sure about this property
> and just tried to derive from other bindings. I don't care for this one,
> so I'm okay with removing it.
Could you send a fixup patch for this?
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
More information about the barebox
mailing list