[PATCH 05/16] fec_imx: Free phy_reset GPIO if when probe fails
Andrey Smirnov
andrew.smirnov at gmail.com
Tue Mar 15 20:33:40 PDT 2016
Signed-off-by: Andrey Smirnov <andrew.smirnov at gmail.com>
---
drivers/net/fec_imx.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/net/fec_imx.c b/drivers/net/fec_imx.c
index da4eb55..e7dbc16 100644
--- a/drivers/net/fec_imx.c
+++ b/drivers/net/fec_imx.c
@@ -701,7 +701,7 @@ static int fec_probe(struct device_d *dev)
ret = gpio_direction_output(phy_reset, 0);
if (ret)
- goto release_res;
+ goto free_gpio;
mdelay(msec);
gpio_set_value(phy_reset, 1);
@@ -741,7 +741,7 @@ static int fec_probe(struct device_d *dev)
}
if (ret)
- goto release_res;
+ goto free_gpio;
fec_init(edev);
@@ -761,6 +761,9 @@ static int fec_probe(struct device_d *dev)
return 0;
+free_gpio:
+ if (gpio_is_valid(phy_reset))
+ gpio_free(phy_reset);
release_res:
release_region(iores);
disable_clk:
--
2.5.0
More information about the barebox
mailing list