[PATCH 1/5] efi: fix memory leak in error path

Sascha Hauer s.hauer at pengutronix.de
Thu Mar 3 22:55:37 PST 2016


On Wed, Mar 02, 2016 at 09:50:33PM +0100, Lucas Stach wrote:
> Signed-off-by: Lucas Stach <dev at lynxeye.de>
> ---
>  arch/efi/efi/efi-device.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

Applied all to master, thanks

Sascha

> 
> diff --git a/arch/efi/efi/efi-device.c b/arch/efi/efi/efi-device.c
> index 7db8e48..678a283 100644
> --- a/arch/efi/efi/efi-device.c
> +++ b/arch/efi/efi/efi-device.c
> @@ -168,8 +168,10 @@ static struct efi_device *efi_add_device(efi_handle_t *handle, efi_guid_t **guid
>  
>  	efiret = BS->open_protocol(handle, &efi_device_path_protocol_guid,
>  			&devpath, NULL, NULL, EFI_OPEN_PROTOCOL_GET_PROTOCOL);
> -	if (EFI_ERROR(efiret))
> +	if (EFI_ERROR(efiret)) {
> +		free(guidarr);
>  		return ERR_PTR(-EINVAL);
> +	}
>  
>  	efidev = xzalloc(sizeof(*efidev));
>  
> -- 
> 2.5.0
> 
> 
> _______________________________________________
> barebox mailing list
> barebox at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



More information about the barebox mailing list