[PATCH v2] input: usb keyboard: fix CTRL+C

[Sascha Hauer]

On Wed, Feb 24, 2016 at 06:53:23PM +0000, Trent Piepho wrote:
> On Wed, 2016-02-24 at 19:12 +0100, Sascha Hauer wrote:
> > > > >  
> > > > > -	if (modstate & (1 << 0))
> > > > > +	if (modstate & (1 << 1))
> > > > > +		ascii = keycode_bb_ctrl_keys[ev->code];
>                 
>            ascii = keycode_bb_keys[ev->code];
>            ascii = ascii >= 'a' ? CTL_CH(ascii): 0;
> 
> > > Sasha, did you mean to eliminate the CTRL-keymap completely?
> > 
> > No, I didn't, although that would be an option aswell. It would safe us
> > a few more bytes in the binary. The question is, how many more keys are
> > in the CTRL map that are interesting for us? Are there more than CTRL-C?
> > If yes, then it's probably better to keep the map. If not, a special
> > CTRL-C case in code might be the better option.
> 
> Would the above, or a slight modification, be ok?  It gets almost all
> the controls keys one could care about.

Yes, this looks good.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |