[PATCH v3 3/3] fs: add support for SquashFS 4.0

[Antony Pavlov]

On Fri, 19 Feb 2016 15:49:15 +0100
yegorslists at googlemail.com wrote:

> From: Yegor Yefremov <yegorslists at googlemail.com>
> 
> The driver was imported from Linux 4.4.
> 
> Current implementation supports only XZ decompressor.
> 
> Cc: Antony Pavlov <antonynpavlov at gmail.com>
> Signed-off-by: Yegor Yefremov <yegorslists at googlemail.com>

I have just tested this series on AR9331-based board, so

Tested-by: Antony Pavlov <antonynpavlov at gmail.com>

However there are some issues, see below

> --- /dev/null
> +++ b/Documentation/filesystems/squashfs.rst
> @@ -0,0 +1,15 @@
> +.. index:: squashfs (filesystem)
> +
> +SquashFS filesystem
> +===================
> +
> +SquashFS is a highly compressed read-only filesystem for Linux.
> +It uses zlib, lzo or xz compression to compress both files, inodes
> +and directories. A SquashFS filesystem can be mounted using the
> +:ref:`command_mount` command::
> +
> +  mkdir /mnt
> +  mount -t squashfs /dev/spiflash.FileSystem /mnt
> +  ls /mnt
> +  zImage barebox.bin
> +  umount /mnt

Please add barebox prompt to this example, e.g.:

barebox:/ mkdir /mnt
barebox:/ mount -t squashfs /dev/spiflash.FileSystem /mnt
barebox:/ ls /mnt
zImage barebox.bin
barebox:/ umount /mnt


I suppose that the 'squashfs squashfs0: squashfs_mount' message is redundant, e.g:

barebox:/ mount -t squashfs /dev/spiflash.linux /mnt/
squashfs squashfs0: squashfs_mount
barebox:/ ls /mnt/
bin        boot       dev        etc        home       init
lib        lib32      linuxrc    media      mnt        opt
proc       root       run        sbin       sys        tmp
usr        var



Also I see a memory leak on mount (By mistake I have tried to mount non-cdev squashfs image):

barebox:/ meminfo
used: 2693564
free: 14074728
barebox:/ mount -t squashfs rootfs.20160223.xz-squashfs /mnt/
squashfs squashfs0: probe failed: Invalid argument
mount: Invalid argument
barebox:/ meminfo
used: 2693636
free: 14074644
barebox:/ mount -t squashfs rootfs.20160223.xz-squashfs /mnt/
squashfs squashfs0: probe failed: Invalid argument
mount: Invalid argument
barebox:/ meminfo
used: 2693748
free: 14074524
barebox:/ mount -t squashfs rootfs.20160223.xz-squashfs /mnt/
squashfs squashfs0: probe failed: Invalid argument
mount: Invalid argument
barebox:/ meminfo
used: 2693832
free: 14074428

-- 
Best regards,
  Antony Pavlov