[PATCH] Print error message if of_state_fixup() fails

Harald Welte laforge at gnumonks.org
Wed Feb 17 10:29:46 PST 2016


If of_state_fixup() fails for some reason, boot/bootm will fail, too

However, it is completely unclear where the error has happened, and to
the user it rather seems like the kernel device tree loaded from some
file was broken/corrupt, not that in fact some fixup routine was
failing.

Adding a meaningful error message can help debugging significantly.

Signed-off-by: Harald Welte <laforge at gnumonks.org>
---
 common/state.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/common/state.c b/common/state.c
index 3e95efd..b55b150 100644
--- a/common/state.c
+++ b/common/state.c
@@ -999,6 +999,7 @@ static int of_state_fixup(struct device_node *root, void *ctx)
 	return 0;
 
  out:
+	dev_err(&state->dev, "error fixing up device tree with boot state\n");
 	of_delete_node(new_node);
 	return ret;
 }
-- 
2.7.0




More information about the barebox mailing list